Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/cascades: add transformation rule PushLimitDownProjcetion #14254

Merged
merged 5 commits into from
Dec 27, 2019
Merged

planner/cascades: add transformation rule PushLimitDownProjcetion #14254

merged 5 commits into from
Dec 27, 2019

Conversation

doggeral
Copy link
Contributor

@doggeral doggeral commented Dec 26, 2019 •
edited
Loading

What problem does this PR solve?

This PR adds Transformation rule which pushes the limit down to projection.

What is changed and how it works?

The logic is the same as pushdownTopN.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

@doggeral doggeral requested a review from a team as a code owner December 26, 2019 09:40
@ghost ghost requested review from alivxxx and lzmhhh123 December 26, 2019 09:40
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 26, 2019
@ghost ghost removed their request for review December 26, 2019 09:40
@francis0407 francis0407 added the sig/planner SIG: Planner label Dec 26, 2019
@francis0407 francis0407 changed the title Add push the limit down to projection. planner/cascades: add transformation rule PushLimitDownProjcetion Dec 27, 2019
francis0407
francis0407 reviewed Dec 27, 2019
View reviewed changes
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I only have a few comments below. LGTM after addressing these comments.

planner/cascades/transformation_rules.go Outdated Show resolved Hide resolved
planner/cascades/transformation_rules.go Outdated Show resolved Hide resolved
francis0407
francis0407 reviewed Dec 27, 2019
View reviewed changes
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407 francis0407 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 27, 2019
@francis0407
Copy link
Member

/run-unit-test

alivxxx
alivxxx reviewed Dec 27, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 27, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 27, 2019

@doggeral merge failed.

@francis0407
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit 7c902dc into pingcap:master Dec 27, 2019
@winoros winoros mentioned this pull request Dec 27, 2019
Open
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francis0407 francis0407 francis0407 left review comments

@alivxxx alivxxx alivxxx approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doggeral @francis0407 @sre-bot @alivxxx